echauchot commented on code in PR #19586:
URL: https://github.com/apache/flink/pull/19586#discussion_r859924128
##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorBaseTest.java:
##########
@@ -97,29 +94,33 @@
import static org.hamcrest.Matchers.samePropertyValuesAs;
import static org.junit.Assert.assertTrue;
-/** IT cases for all cassandra sinks. */
+/**
+ * Base class for IT cases for all Cassandra sinks. This class relies on
Cassandra testContainer
+ * that needs to use a ClassRule. Parametrized tests to not work with
ClassRules so the actual
+ * testCase classes define the tested version and manage the container.
+ */
@SuppressWarnings("serial")
// NoHostAvailableException is raised by Cassandra client under load while
connecting to the cluster
@RetryOnException(times = 3, exception = NoHostAvailableException.class)
-public class CassandraConnectorITCase
+public abstract class CassandraConnectorBaseTest
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
