zentol commented on code in PR #19586:
URL: https://github.com/apache/flink/pull/19586#discussion_r859979874
##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorBaseTest.java:
##########
@@ -220,7 +225,7 @@ private static Class<? extends Pojo>
annotatePojoWithTable(String keyspace, Stri
}
@NotNull
- private static Table createTableAnnotation(String keyspace, String
tableName) {
+ private Table createTableAnnotation(String keyspace, String tableName) {
Review Comment:
Why shouldn't it have been static in the first place? The general rule is
"if it can be static, make it static.".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
