zentol commented on code in PR #19567:
URL: https://github.com/apache/flink/pull/19567#discussion_r860641365
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -659,14 +661,36 @@ private CompletableFuture<CleanupJobState>
handleJobManagerRunnerResult(
return
jobReachedTerminalState(jobManagerRunnerResult.getExecutionGraphInfo());
}
- enum CleanupJobState {
- LOCAL,
- GLOBAL
+ private static class CleanupJobStateWithJobStatusIfGlobal {
+
+ private static final CleanupJobStateWithJobStatusIfGlobal LOCAL =
+ new CleanupJobStateWithJobStatusIfGlobal(null);
+
+ @Nullable private final JobStatus jobStatus;
+
+ public static CleanupJobStateWithJobStatusIfGlobal
globalCleanup(JobStatus jobStatus) {
Review Comment:
strange that jobStatus isn't nullable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
