zentol commented on code in PR #19567:
URL: https://github.com/apache/flink/pull/19567#discussion_r860644917
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -659,14 +661,36 @@ private CompletableFuture<CleanupJobState>
handleJobManagerRunnerResult(
return
jobReachedTerminalState(jobManagerRunnerResult.getExecutionGraphInfo());
}
- enum CleanupJobState {
- LOCAL,
- GLOBAL
+ private static class CleanupJobStateWithJobStatusIfGlobal {
+
+ private static final CleanupJobStateWithJobStatusIfGlobal LOCAL =
+ new CleanupJobStateWithJobStatusIfGlobal(null);
Review Comment:
Do we really need a nullable jobstatus in the first place?
* jobManagerRunnerFailed could use initializing
* jobReachedTerminalState could use suspended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
