masteryhx commented on code in PR #19598:
URL: https://github.com/apache/flink/pull/19598#discussion_r861907199
##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java:
##########
@@ -132,8 +135,13 @@ public synchronized void close() {
public void triggerMaterialization() {
mailboxExecutor.execute(
() -> {
- Optional<MaterializationRunnable>
materializationRunnableOptional =
- keyedStateBackend.initMaterialization();
+ Optional<MaterializationRunnable>
materializationRunnableOptional;
+ try {
+ materializationRunnableOptional =
keyedStateBackend.initMaterialization();
+ } catch (Exception ex) {
+ metrics.reportFailedMaterialization();
+ throw ex;
Review Comment:
I think maybe it's useful for users to see the metric history and find the
materilization failure even if the job have restored and ran some times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
