zentol commented on PR #19624: URL: https://github.com/apache/flink/pull/19624#issuecomment-1115850613
I don't necessarily mind it, but do think that we should figure out the responsibilities a bit. Currently, a test can select certain classes to test via the ImportOptions. This newly added import option would push the responsibility of selecting production code to the test. But then we have rules (like the Visibility thing) that select production code on their own. So who's responsible for selecting production source code? And if we're going with both the user and rule having the capability to do so, then they should rely on the same logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
