JingGe commented on PR #19624: URL: https://github.com/apache/flink/pull/19624#issuecomment-1116222227
@Airblader After talking with @zentol offline and checking the archunit doc again. I think, theoretically, class path should only be managed by the test via `@AnalyzeClasses(...ImportOptions...)`. It should work without adding the SourcePredicates#areProductionCode logic into the rule definition. There might be some corner case I am not aware of. May I have your thoughts of why developing the `SourcePredicates`? Is there anything that `SourcePredicates` could do but customized `ImportOption`s could not do? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
