MartijnVisser commented on code in PR #15:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864778551
##########
pom.xml:
##########
@@ -393,67 +338,13 @@ under the License.
<version>3.3.2</version>
</dependency>
- <dependency>
- <groupId>org.xerial.snappy</groupId>
- <artifactId>snappy-java</artifactId>
- <version>1.1.8.3</version>
- </dependency>
-
- <dependency>
- <groupId>org.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.github.oshi</groupId>
- <artifactId>oshi-core</artifactId>
- <version>3.4.0</version>
- </dependency>
-
- <!-- We no longer align the avro version with the
version bundled in Hadoop.
- Users might need to downgrade the avro version for a
particular Hadoop version. -->
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
<!-- For dependency convergence -->
<dependency>
Review Comment:
I still see Hamcrest being used in the Java code unfortunately...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
