MartijnVisser commented on code in PR #15:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864791619
##########
flink-connector-elasticsearch7/pom.xml:
##########
@@ -81,20 +81,6 @@ under the License.
<groupId>org.elasticsearch.client</groupId>
<artifactId>elasticsearch-rest-high-level-client</artifactId>
<version>${elasticsearch.version}</version>
- <!-- elasticsearch-rest-client includes two different
versions of httpcore-nio -->
- <exclusions>
- <exclusion>
-
<groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpcore-nio</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- We need to include httpcore-nio again in the correct
version due to the exclusion above -->
- <dependency>
Review Comment:
Thanks. I'll also add that to the pipeline, that must be there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
