wangyang0918 commented on code in PR #19630:
URL: https://github.com/apache/flink/pull/19630#discussion_r866456771
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java:
##########
@@ -498,6 +498,12 @@ public class KubernetesConfigOptions {
"Whether to enable HostNetwork mode. "
+ "The HostNetwork allows the pod could
use the node network namespace instead of the individual pod network namespace.
Please note that the JobManager service account should have the permission to
update Kubernetes service.");
+ public static final ConfigOption<String> KUBERNETES_KUBECLIENT_USER_AGENT =
+ key("kubernetes.kubeclient.user-agent")
+ .stringType()
+ .defaultValue("flink")
+ .withDescription("The user agent passed to the kube
client");
Review Comment:
```suggestion
.withDescription("The user agent to be used for
contacting with Kubernetes APIServer.");
```
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java:
##########
@@ -498,6 +498,12 @@ public class KubernetesConfigOptions {
"Whether to enable HostNetwork mode. "
+ "The HostNetwork allows the pod could
use the node network namespace instead of the individual pod network namespace.
Please note that the JobManager service account should have the permission to
update Kubernetes service.");
+ public static final ConfigOption<String> KUBERNETES_KUBECLIENT_USER_AGENT =
Review Comment:
Following the naming pattern `kubernetes.client.io-pool.size`, maybe
`kubernetes.client.user-agent` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
