wangyang0918 commented on code in PR #195:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r867299797


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -211,6 +220,22 @@ protected boolean isSuspendedJob(FlinkDeployment 
deployment) {
                 && lastReconciledSpec.getJob().getState() == 
JobState.SUSPENDED;
     }
 
+    private void onMissingDeployment(FlinkDeployment deployment) {
+        String err = "Missing JobManager deployment";
+        logger.error(err);

Review Comment:
   My bad. We might not need to add namespace and name here. MDC add this. We 
also do not need this for the event. It is duplicated.
   
   ```
   wangyang-pc:flink-kubernetes-operator danrtsey.wy$ kubectl get events | grep 
'flinkdeployment/flink-example-statemachine'
   11h         Error     Missing JobManager deployment for 
default/flink-example-statemachine   flinkdeployment/flink-example-statemachine 
        Missing JobManager deployment for default/flink-example-statemachine
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to