[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #195: [FLINK-27468] Recover missing deployments and other cancel/upgrade improvements for 1.15

Sat, 07 May 2022 00:26:27 -0700 


gyfora commented on code in PR #195:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r867317503


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -211,6 +220,22 @@ protected boolean isSuspendedJob(FlinkDeployment 
deployment) {
                 && lastReconciledSpec.getJob().getState() == 
JobState.SUSPENDED;
     }
 
+    private void onMissingDeployment(FlinkDeployment deployment) {
+        String err = "Missing JobManager deployment";
+        logger.error(err);
+        Event event =
+                DeploymentFailedException.asEvent(
+                        new DeploymentFailedException(
+                                
DeploymentFailedException.COMPONENT_JOBMANAGER, "Error", err),
+                        deployment);
+        kubernetesClient

Review Comment:
   Pushed a fix for this:
   <img width="608" alt="image" 
src="https://user-images.githubusercontent.com/5880972/167243744-4aa470d0-03ab-4366-9d7d-a571fecf88ae.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to