LadyForest commented on code in PR #111:
URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868767378
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java:
##########
@@ -69,7 +92,10 @@ public FileStoreSource(
boolean latestContinuous,
@Nullable int[][] projectedFields,
@Nullable Predicate partitionPredicate,
- @Nullable Predicate fieldPredicate) {
+ @Nullable Predicate fieldPredicate,
+ @Nullable Long specifiedSnapshotId,
+ @Nullable
+ Map<BinaryRowData, Map<Integer, List<DataFileMeta>>>
specifiedManifestEntries) {
Review Comment:
> What's the case that we will set those two fields with non-null values ? I
see all of them will be set to be `null` in the `buildFileStore`.
For `ALTER TABLE ... COMPACT`, the `buildFileStore` will be modified in the
following PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
