LadyForest commented on code in PR #111:
URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868906444
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java:
##########
@@ -61,6 +72,13 @@
@Nullable private final Predicate fieldPredicate;
+ /** The latest snapshot id seen at planning phase when manual compaction
is triggered. */
+ @Nullable private final Long specifiedSnapshotId;
+
+ /** The manifest entries collected at planning phase when manual
compaction is triggered. */
+ @Nullable
+ private transient Map<BinaryRowData, Map<Integer, List<DataFileMeta>>>
specifiedManifestEntries;
Review Comment:
> Can we just create a `SpecificDataFiles` class which implements
`Serializable`. And
>
> * `Preconditions.checkNotNull(specifiedManifestEntries)` should in it.
> * We dont need to have a `PartitionedDataManifestSerializer`.
Do you mean creating a new serializable class like
```java
public class SpecificDataFiles implements Serializable {
Map<BinaryRowData, Map<Integer, List<DataFileMeta>>> meta;
}
```
Correct me if I'm wrong, but `BinaryRowData` and `DataFileMeta` are still
not serializable, anyway we need to implement the ser/deser logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
