fapaul commented on code in PR #19655: URL: https://github.com/apache/flink/pull/19655#discussion_r868894146
########## flink-connectors/flink-connector-upsert-test/src/main/java/org/apache/flink/connector/upserttest/sink/BinaryFileUtil.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.upserttest.sink; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.serialization.DeserializationSchema; + +import java.io.BufferedInputStream; +import java.io.BufferedOutputStream; +import java.io.File; +import java.io.FileInputStream; +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.HashMap; +import java.util.Iterator; +import java.util.Map; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** Collection uf utility methods for tests using the {@link UpsertTestSink}. */ +@Internal +public class BinaryFileUtil { Review Comment: > I previously wanted to use the SimpleVersionedSerializer and SimpleVersionedSerialization. However implementing this interface adds the same kind of code we already have in place. That is exactly the idea. Of course, the interface adds the same logic but it makes understanding the code easier because other Flink developers are used to `SimpleVersionedSerializer`. > Also the SimpleVersionedSerialization only takes single byte arrays as input so then we would have to write another method around that to allow both key and value as input. And finally it does not provide a simple entrypoint for reading back all elements so I decided against that, This point I do not fully understand. My idea was to have the following ```java class UpsertFileSinkSerializer implements SimpleVersionedSerializer<Map<ByteBuffer, ByteBuffer>> { .... } ``` and `SimpleVersionedSerialization#readVersionAndDeSerialize` or `SimpleVersionedSerialization#writeVersionAndSerialize`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
