Myasuka commented on code in PR #19502:
URL: https://github.com/apache/flink/pull/19502#discussion_r869059525
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,24 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ?
'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr
+ *ngIf="
Review Comment:
I think we can add a more line to tell whether changelog state-backend is
enabled. If enabled, we print `true` with two more lines. Otherwise, we just
print `false` without another two lines.
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,24 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ?
'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr
+ *ngIf="
+ checkPointConfig['state_backend'] === 'ChangelogStateBackend' &&
+ checkPointConfig['interval'] !== '0x7fffffffffffffff'
Review Comment:
Actually, even we do not set the checkpoint interval, the changelog
state-backend is still enabled. Thus, I think we don't need to check the
checkpoint interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
