Myasuka commented on code in PR #19502:
URL: https://github.com/apache/flink/pull/19502#discussion_r869823074
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,19 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ?
'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr>
+ <td>Changelog</td>
Review Comment:
I think the description of `Changelog state-backend` looks better.
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,19 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ?
'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr>
+ <td>Changelog</td>
+ <td *ngIf="checkPointConfig['state_backend'] ===
'ChangelogStateBackend'">Enabled</td>
+ <td *ngIf="checkPointConfig['state_backend'] !==
'ChangelogStateBackend'">Disabled</td>
+ </tr>
+ <tr *ngIf="checkPointConfig['state_backend'] ===
'ChangelogStateBackend'">
+ <td>Changelog Storage</td>
+ <td>{{ checkPointConfig['changelog_storage'] }}</td>
+ </tr>
+ <tr *ngIf="checkPointConfig['state_backend'] ===
'ChangelogStateBackend'">
+ <td>Changelog Periodic Materialization Interval</td>
+ <td>{{
checkPointConfig['changelog_periodic_materialization_interval'] }}</td>
Review Comment:
I noticed that the curent UI does not show the time unit of interval.
I think you can change this to `{{
checkPointConfig['changelog_periodic_materialization_interval'] |
humanizeDuration}}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
