afedulov commented on code in PR #19228:
URL: https://github.com/apache/flink/pull/19228#discussion_r869087760
##########
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/threadinfo/JobVertexThreadInfoTracker.java:
##########
@@ -204,31 +206,33 @@ private void triggerThreadInfoSampleInternal(
}
}
- private Map<Set<ExecutionAttemptID>,
CompletableFuture<TaskExecutorThreadInfoGateway>>
+ private Map<ImmutableSet<ExecutionAttemptID>,
CompletableFuture<TaskExecutorThreadInfoGateway>>
matchExecutionsWithGateways(
AccessExecutionVertex[] executionVertices,
ResourceManagerGateway resourceManagerGateway) {
// Group executions by their TaskManagerLocation to be able to issue
one sampling
// request per TaskManager for all relevant tasks at once
- final Map<TaskManagerLocation, Set<ExecutionAttemptID>>
executionsByLocation =
+ final Map<TaskManagerLocation, ImmutableSet<ExecutionAttemptID>>
executionsByLocation =
Review Comment:
Yes, I thought it is better to keep it explicit because the value later
becomes the key, and we want to make sure we use immutable sets as keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
