gyfora commented on code in PR #201:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/201#discussion_r869388274
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -192,7 +194,8 @@ private JarRunResponseBody runJar(
job.getParallelism() > 0 ? job.getParallelism() :
null,
jobID,
job.getAllowNonRestoredState(),
- savepoint);
+ savepoint,
+ RestoreMode.DEFAULT);
Review Comment:
Based on the CI we should only set the RestoreMode if version is newer than
1.14 otherwise set null
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -491,7 +499,11 @@ public void triggerSavepoint(
.sendRequest(
savepointTriggerHeaders,
savepointTriggerMessageParameters,
- new
SavepointTriggerRequestBody(savepointDirectory, false))
+ new SavepointTriggerRequestBody(
+ savepointDirectory,
+ false,
+ SavepointFormatType.DEFAULT,
Review Comment:
Only set formatType if version newer than 1.14 otherwise set null
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -349,7 +352,8 @@ public void cancelJob(FlinkDeployment deployment,
UpgradeMode upgradeMode) throw
.stopWithSavepoint(
Preconditions.checkNotNull(jobId),
false,
- savepointDirectory)
+ savepointDirectory,
+
SavepointFormatType.DEFAULT)
Review Comment:
Only set formatType if version newer than 1.14 otherwise set null
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -447,7 +451,11 @@ public Optional<String> cancelSessionJob(
try {
String savepoint =
clusterClient
- .stopWithSavepoint(jobID, false,
savepointDirectory)
+ .stopWithSavepoint(
+ jobID,
+ false,
+ savepointDirectory,
+ SavepointFormatType.DEFAULT)
Review Comment:
Only set formatType if version newer than 1.14 otherwise set null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
