gyfora commented on code in PR #201:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/201#discussion_r870949470
##########
.github/workflows/ci.yml:
##########
@@ -41,10 +41,10 @@ jobs:
- name: Build with Maven
run: |
set -o pipefail; mvn clean install -Pgenerate-docs | tee ./mvn.log;
set +o pipefail
- if [[ $(grep -c "overlapping classes" ./mvn.log) -gt 0 ]];then
- echo "Found overlapping classes, please fix"
- exit 1
- fi
+ #if [[ $(grep -c "overlapping classes" ./mvn.log) -gt 0 ]];then
+ # echo "Found overlapping classes, please fix"
+ # exit 1
+ #fi
Review Comment:
It would be nice to specifically ignore only the errors we introduced by
those 2 classes and not turn off this completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
