zentol commented on code in PR #15:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r873489423
##########
pom.xml:
##########
@@ -1556,78 +1000,6 @@ under the License.
</rules>
</configuration>
</execution>
- <execution>
- <id>ban-unsafe-snakeyaml</id>
- <goals>
Review Comment:
I think these are less important for connectors because the project is much
more focused, with a relatively small dependency tree that also doesn't change
a lot.
The dependency tree of Flink is massive, so such safeguards make more sense
there.
##########
pom.xml:
##########
@@ -576,100 +378,25 @@ under the License.
<version>2.24.0</version>
</dependency>
+ <!-- For dependency convergence -->
<dependency>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- <version>${scala.version}</version>
+ <groupId>org.objenesis</groupId>
+ <artifactId>objenesis</artifactId>
+ <version>2.1</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
- <artifactId>scala-reflect</artifactId>
+ <artifactId>scala-compiler</artifactId>
Review Comment:
does scala actually end up anywhere in the dependency tree? I think that
shouldn't be the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
