openinx commented on PR #126: URL: https://github.com/apache/flink-table-store/pull/126#issuecomment-1131320994
> What is the strategy for assigning buckets to record, randomly? For append-only table, the assignment policy is determined by the SinkRecordConverter#bucket, which will just calculate the hash code of the whole row to get the correct bucket. I think it it the correct direction to go. > FileStoreSourceSplitGenerator needs break bucket to multiply splits per file. Yeah, this is a great question which I did not address in this PR currently now. I've just filed a separate issue to address it so that we can add separate unit tests for it. Pls see: https://issues.apache.org/jira/browse/FLINK-27696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
