alpreu commented on code in PR #19660:
URL: https://github.com/apache/flink/pull/19660#discussion_r876807318
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java:
##########
@@ -679,10 +666,9 @@ private void testFailingConsumerLifecycle(
"Exception should have been thrown from open / run method
of FlinkKafkaConsumerBase.");
} catch (Exception e) {
assertThat(
- ExceptionUtils.findThrowable(
- e, throwable ->
throwable.equals(expectedException))
- .isPresent(),
- is(true));
+ ExceptionUtils.findThrowable(
Review Comment:
I left it as is for now as we discussed offline to not touch the tests for
deprecated components
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java:
##########
@@ -165,13 +167,13 @@ public void testAsyncErrorRethrownOnInvoke() throws
Throwable {
testHarness.processElement(new StreamRecord<>("msg-2"));
} catch (Exception e) {
// the next invoke should rethrow the async exception
- Assert.assertTrue(e.getCause().getMessage().contains("artificial
async exception"));
+ assertThat(e.getCause().getMessage()).contains("artificial async
exception");
Review Comment:
I left it as is for now as we discussed offline to not touch the tests for
deprecated components
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
