pnowojski commented on code in PR #19723:
URL: https://github.com/apache/flink/pull/19723#discussion_r876807705
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java:
##########
@@ -103,6 +112,14 @@ class SubtaskCheckpointCoordinatorImpl implements
SubtaskCheckpointCoordinator {
@GuardedBy("lock")
private boolean closed;
+ private final BiFunction<Callable<?>, Duration, Cancellable> registerTimer;
+
+ private final Clock clock;
+
+ /** Hold the AlignmentTimer for each checkpointId. */
+ @GuardedBy("lock")
Review Comment:
What do you mean?
`SingleCheckpointBarrierHandler#resetAlignmentTimer` should only be called
from the task thread as well.
However I don't see where `SubtaskCheckpointCoordinatorImpl#close()` is
being called/used... That might be a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
