pnowojski commented on code in PR #19723:
URL: https://github.com/apache/flink/pull/19723#discussion_r877954907
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java:
##########
@@ -103,6 +112,14 @@ class SubtaskCheckpointCoordinatorImpl implements
SubtaskCheckpointCoordinator {
@GuardedBy("lock")
private boolean closed;
+ private final BiFunction<Callable<?>, Duration, Cancellable> registerTimer;
+
+ private final Clock clock;
+
+ /** Hold the AlignmentTimer for each checkpointId. */
+ @GuardedBy("lock")
Review Comment:
> So could I fix the bug in other ticket? I can create a new JIRA.
Yes, that would be great. You could fix it in separate PR or as separate
commit in this PR - whatever is more convenient for you :)
> And I don't consider this multi-thread for alignmentTimer, right?
alignmentTimer goes through the mailbox, as such it's also executed in the
task thread, so this also doesn't require extra synchronisation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
