LadyForest commented on code in PR #119:
URL: https://github.com/apache/flink-table-store/pull/119#discussion_r876862012
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactory.java:
##########
@@ -309,4 +360,41 @@ TableStore buildTableStore(Context context) {
return store;
}
+
+ private Map<BinaryRowData, Map<Integer, List<DataFileMeta>>> pickManifest(
+ Map<BinaryRowData, Map<Integer, List<DataFileMeta>>> groupBy,
+ MergeTreeOptions options,
+ List<LogicalType> keyTypes) {
+ Map<BinaryRowData, Map<Integer, List<DataFileMeta>>> filteredGroupBy =
new HashMap<>();
+ Comparator<RowData> keyComparator =
+ CodeGenUtils.generateRecordComparator(new TableConfig(),
keyTypes, "KeyComparator")
+
.newInstance(Thread.currentThread().getContextClassLoader());
Review Comment:
> Let's make this into a separate method in a utility class ?
Yes, it has some duplicate logic here. Also, I was wondering if
`FileStoreImpl` could expose `newKeyComparator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
