LadyForest commented on code in PR #119:
URL: https://github.com/apache/flink-table-store/pull/119#discussion_r876865249
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java:
##########
@@ -258,16 +269,17 @@ private long discoveryIntervalMills() {
private FileStoreSource buildFileSource(
boolean isContinuous, boolean continuousScanLatest) {
+ FileStore fileStore = buildFileStore();
return new FileStoreSource(
- buildFileStore(),
+ fileStore,
schema.primaryKeys().isEmpty(),
isContinuous,
discoveryIntervalMills(),
continuousScanLatest,
projectedFields,
partitionPredicate,
fieldPredicate,
- null);
+ ((FileStoreImpl) fileStore).getSpecifiedPartitionedMeta());
Review Comment:
> It makes more sense to get this `partitionedMeta` by parsing the flink
options again (or adding an extra `withPartitionedMeta` in this `SourceBuilder`
with the parsed value ) , rather than getting it from a casted `FileStore`
implementation.
Actually, I did this in the previous version and wondered why we repeatedly
parsed this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
