xinbinhuang commented on code in PR #17873:
URL: https://github.com/apache/flink/pull/17873#discussion_r877378398
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/JSONGenerator.java:
##########
@@ -184,6 +185,8 @@ private void decorateNode(Integer vertexID, ObjectNode
node) {
node.put(CONTENTS, vertex.getOperatorDescription());
+ node.put(SLOT_SHARING_GROUP, vertex.getSlotSharingGroup());
Review Comment:
I'm not 100% sure. It's only directly called
[here](https://github.com/apache/flink/blob/b4bb9c8bffe1e37ad6912348d8b3bef89af42286/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java#L998)
(though it get called indirectly in several other places
<img width="1318" alt="Screen Shot 2022-05-19 at 11 05 22 AM"
src="https://user-images.githubusercontent.com/27927454/169369361-a7d0de51-4c73-45ca-b783-0594d67af4e3.png";>
From the tests result, I believe it's properly set in both the Table batch
and streaming planner. So I think it's fine, but I can also add the checks for
extra safety?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/27927454/169369361-a7d0de51-4c73-45ca-b783-0594d67af4e3.png"](https://user-images.githubusercontent.com/27927454/169369361-a7d0de51-4c73-45ca-b783-0594d67af4e3.png"){kind=link}