[GitHub] [flink] xinbinhuang commented on a diff in pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

Thu, 19 May 2022 11:23:35 -0700 


xinbinhuang commented on code in PR #17873:
URL: https://github.com/apache/flink/pull/17873#discussion_r877396998


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/JSONGenerator.java:
##########
@@ -184,6 +185,8 @@ private void decorateNode(Integer vertexID, ObjectNode 
node) {
 
         node.put(CONTENTS, vertex.getOperatorDescription());
 
+        node.put(SLOT_SHARING_GROUP, vertex.getSlotSharingGroup());

Review Comment:
   Assuming `env.getStreamGraph().getStreamingPlanAsJSON()` is the majority way 
to get the JSON plan. Then I believe the `slotSharingGroup` is properly set 
whenever `env.getStreamGraph()` is called. Here is the call stacks for the 
relevant part
   
   <img width="2398" alt="Screen Shot 2022-05-19 at 11 22 55 AM" 
src="https://user-images.githubusercontent.com/27927454/169372921-f9233961-2fe9-4197-bb03-b093b3496816.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to