yunfengzhou-hub commented on code in PR #95:
URL: https://github.com/apache/flink-ml/pull/95#discussion_r877917528
##########
flink-ml-dist/pom.xml:
##########
@@ -19,14 +19,17 @@ under the License.
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
<modelVersion>4.0.0</modelVersion>
+ <properties>
+ <statefun-flink-core.version>3.2.0</statefun-flink-core.version>
+ </properties>
Review Comment:
nit: Let's move this property to the parent pom.xml and reuse this property
in flink-ml-dist and flink-ml-iteration pom files.
Besides, `statefun.version` might be enough while more concise.
##########
flink-ml-lib/src/test/java/org/apache/flink/ml/clustering/OnlineKMeansTest.java:
##########
@@ -407,13 +415,15 @@ public void testSaveAndReload() throws Exception {
transformAndOutputData(loadedOnlineModel);
- miniCluster.submitJob(env.getStreamGraph().getJobGraph());
- waitInitModelDataSetup();
+ final JobSubmissionResult jobSubmissionResult =
+
miniCluster.submitJob(env.getStreamGraph().getJobGraph()).get();
+ final JobID jobID = jobSubmissionResult.getJobID();
Review Comment:
nit: I noticed that some tests uses
```java
final JobSubmissionResult jobSubmissionResult =
miniCluster.submitJob(env.getStreamGraph().getJobGraph()).get();
final JobID jobID = jobSubmissionResult.getJobID();
```
while others use
```java
final JobGraph jobGraph = env.getStreamGraph().getJobGraph();
miniCluster.submitJob(jobGraph);
final JobID jobID = jobGraph.getJobID();
```
And I think it might be better to unify the practice across all
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
