dotbg commented on code in PR #95:
URL: https://github.com/apache/flink-ml/pull/95#discussion_r877950128
##########
flink-ml-lib/src/test/java/org/apache/flink/ml/clustering/OnlineKMeansTest.java:
##########
@@ -407,13 +415,15 @@ public void testSaveAndReload() throws Exception {
transformAndOutputData(loadedOnlineModel);
- miniCluster.submitJob(env.getStreamGraph().getJobGraph());
- waitInitModelDataSetup();
+ final JobSubmissionResult jobSubmissionResult =
+
miniCluster.submitJob(env.getStreamGraph().getJobGraph()).get();
+ final JobID jobID = jobSubmissionResult.getJobID();
Review Comment:
Generally, I'd like to avoid using `Future.get()` without a timeout. Is it
ok to assume 1 second?
I could chain the test as well, but this may make the code way harder to
follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
