alpreu commented on code in PR #19655: URL: https://github.com/apache/flink/pull/19655#discussion_r877946191
########## flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/connector/upserttest/sink/ImmutableByteArrayWrapper.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.upserttest.sink; + +import org.apache.flink.annotation.VisibleForTesting; + +import java.util.Arrays; +import java.util.Map; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * This class is a slim wrapper around {@code byte[]} that defensively copies the array during + * construction and retrieval to prevent its contents from changing. It also implements a + * content-dependent {@link #hashCode} method to allow usage as keys in a {@link Map}. + */ +class ImmutableByteArrayWrapper { + + @VisibleForTesting final byte[] bytes; + + ImmutableByteArrayWrapper(byte[] bytes) { + checkNotNull(bytes); + this.bytes = bytes.clone(); + } + + /** + * Returns a reference-free copy of the underlying byte[]. + * + * @return the copied byte[] + */ + byte[] array() { + return bytes.clone(); Review Comment: I think this depends on the usage, right now it would prevent that changes to the returned byte[] modify the content of the Wrapper class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
