alpreu commented on code in PR #19655: URL: https://github.com/apache/flink/pull/19655#discussion_r877950300
########## flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/connector/upserttest/sink/UpsertTestSinkWriter.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.upserttest.sink; + +import org.apache.flink.api.common.serialization.SerializationSchema; +import org.apache.flink.api.connector.sink2.SinkWriter; +import org.apache.flink.util.FlinkRuntimeException; + +import java.io.BufferedOutputStream; +import java.io.File; +import java.io.FileNotFoundException; +import java.io.FileOutputStream; +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * This class is responsible for writing records into a file in an upsert-fashion. On every + * checkpoint each key-value pair currently in the map is written to the file. + * + * @param <IN> The type of the input elements. + */ +class UpsertTestSinkWriter<IN> implements SinkWriter<IN> { + static final byte MAGIC_BYTE = 13; + + private final SerializationSchema<IN> keySerializationSchema; + private final SerializationSchema<IN> valueSerializationSchema; + private final Map<ImmutableByteArrayWrapper, ImmutableByteArrayWrapper> records = + new HashMap<>(); + private final BufferedOutputStream bufferedOutputStream; + + UpsertTestSinkWriter( + File outputFile, + SerializationSchema<IN> keySerializationSchema, + SerializationSchema<IN> valueSerializationSchema) { + this.keySerializationSchema = checkNotNull(keySerializationSchema); + this.valueSerializationSchema = checkNotNull(valueSerializationSchema); + checkNotNull(outputFile); + try { + this.bufferedOutputStream = + new BufferedOutputStream(new FileOutputStream(outputFile, true)); + } catch (FileNotFoundException e) { + throw new FlinkRuntimeException("Could not find file", e); + } + } + + @Override + public void write(IN element, Context context) { + byte[] key = keySerializationSchema.serialize(element); + byte[] value = valueSerializationSchema.serialize(element); + records.put(new ImmutableByteArrayWrapper(key), new ImmutableByteArrayWrapper(value)); + } + + @Override + public void flush(boolean endOfInput) throws IOException { + writeRecords(bufferedOutputStream, records); + records.clear(); + } + + @Override + public void close() throws Exception { + flush(true); + bufferedOutputStream.close(); + } + + private static void writeRecords( Review Comment: I agree, Arvid preferred to have it as a public part of the Sink but this introduces the separation. I think the question then becomes do we make the Writer public and have the reading in there or do we reintroduce a util class for reading and writing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
