[
https://issues.apache.org/jira/browse/FLINK-27725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540877#comment-17540877
]
Timo Walther commented on FLINK-27725:
--------------------------------------
What do you mean with "connector is not table-only"? The concept of an "upsert
sink" makes only sense in the Table/SQL ecosystem. The `flink-table-test-utils`
is intended to provide everything usually required to properly test your
implementation. A mocking source and sink sounds like a default to me. The
other connectors only depend on `flink-table-planner` in `test` scope, I guess
this is only due to the test utilities. It would be great to not rely on legacy
dependencies in new connectors and follow the new design if possible.
> Create tests for TypeInformation and TypeSerializer classes in table
> --------------------------------------------------------------------
>
> Key: FLINK-27725
> URL: https://issues.apache.org/jira/browse/FLINK-27725
> Project: Flink
> Issue Type: Technical Debt
> Components: Table SQL / Runtime
> Affects Versions: 1.16.0
> Reporter: Alexander Preuss
> Priority: Major
>
> During the implementation of FLINK-27527 we had to add `flink-table-planner`
> as a dependency to `flink-tests`.
> This created test failures for the reflection tests checking test coverage
> for `TypeInformation` and `TypeSerializer` classes as shown here:
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=35851&view=logs&j=56de72e1-1902-5ae5-06bd-77ee907eed59&t=237d25ca-be06-5918-2b0a-41d0694dace8&l=6738]
> To mitigate the issue and unblock FLINK-27527 we extended the whitelist as a
> temporary solution but there should be a better solution in place. Some of
> the classes are deprecated but others are not and should probably have tests
> created to improve the coverage.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
