[ 
https://issues.apache.org/jira/browse/FLINK-27725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540897#comment-17540897
 ] 

Alexander Preuss commented on FLINK-27725:
------------------------------------------

Maybe the initial description was ambiguous. The `flink-table-planner` 
dependency we are talking about always referred to a test dependency, it is not 
a compile dependency for `flink-test` or any other connector right now. For all 
connectors the planner is included as a test dependency because without it 
either the ExecutorFactory is not present or, using the 
`flink-table-planner-loader` we run into exceptions as I described above.

I agree that an upsert sink only makes sense in Tableland, but I think the idea 
of having a very simple file-based sink for general testing scenarios is 
valuable for DataStream as well. The alternative option available to developers 
right now is the FileSink which is a lot more complex.

> Create tests for TypeInformation and TypeSerializer classes in table
> --------------------------------------------------------------------
>
>                 Key: FLINK-27725
>                 URL: https://issues.apache.org/jira/browse/FLINK-27725
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Table SQL / Runtime
>    Affects Versions: 1.16.0
>            Reporter: Alexander Preuss
>            Priority: Major
>
> During the implementation of FLINK-27527 we had to add `flink-table-planner` 
> as a dependency to `flink-tests`.
> This created test failures for the reflection tests checking test coverage 
> for `TypeInformation` and `TypeSerializer` classes as shown here:
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=35851&view=logs&j=56de72e1-1902-5ae5-06bd-77ee907eed59&t=237d25ca-be06-5918-2b0a-41d0694dace8&l=6738]
> To mitigate the issue and unblock FLINK-27527 we extended the whitelist as a 
> temporary solution but there should be a better solution in place. Some of 
> the classes are deprecated but others are not and should probably have tests 
> created to improve the coverage.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to