[ 
https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446140#comment-15446140
 ] 

ASF GitHub Bot commented on FLINK-4496:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2434#discussion_r76624448
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java
 ---
    @@ -71,8 +71,7 @@ public MockRuntimeContext(
                ExecutionConfig execConfig,
                Object checkpointLock) {
     
    -           this(numberOfParallelSubtasks, indexOfThisSubtask, execConfig, 
checkpointLock,
    -                   
DefaultTimeServiceProvider.create(Executors.newSingleThreadScheduledExecutor()));
    +           this(numberOfParallelSubtasks, indexOfThisSubtask, execConfig, 
checkpointLock, null);
    --- End diff --
    
    Instead of passing `null` you can directly insert this line from below: 
`DefaultTimeServiceProvider.createForTesting(Executors.newSingleThreadScheduledExecutor(),
 this.checkpointLock)` and avoid the null check below.


> Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-4496
>                 URL: https://issues.apache.org/jira/browse/FLINK-4496
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to