[ 
https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510269#comment-15510269
 ] 

ASF GitHub Bot commented on FLINK-4496:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2434#discussion_r79854646
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ---
    @@ -326,6 +322,9 @@ public Long getValue() {
                        // stop all timers and threads
                        if (timerService != null) {
                                try {
    +                                   if (!timerService.isTerminated()) {
    --- End diff --
    
    Should the actual call to `shutdownService()` also be inside the if block?


> Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-4496
>                 URL: https://issues.apache.org/jira/browse/FLINK-4496
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to