wsry commented on code in PR #19653:
URL: https://github.com/apache/flink/pull/19653#discussion_r882378865
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/TaskExecutorPartitionTrackerImpl.java:
##########
@@ -141,12 +146,20 @@ void addPartition(ResultPartitionID resultPartitionId) {
partitionIds.add(resultPartitionId);
}
+ void addShuffleDescriptor(ShuffleDescriptor shuffleDescriptor) {
Review Comment:
nit: can we merge addPartition and addShuffleDescriptor into one method? For
example:
void addPartition(ShuffleDescriptor shuffleDescriptor) {
partitionIds.add(shuffleDescriptor.getResultPartitionID());
shuffleDescriptors.add(shuffleDescriptor);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
