wsry commented on code in PR #19653:
URL: https://github.com/apache/flink/pull/19653#discussion_r882402534
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/DataSetMetaInfo.java:
##########
@@ -44,6 +48,14 @@ public int getNumTotalPartitions() {
return numTotalPartitions;
}
+ public void addShuffleDescriptors(Set<ShuffleDescriptor>
shuffleDescriptors) {
+ this.shuffleDescriptors.addAll(shuffleDescriptors);
Review Comment:
We use set here to track shuffle descriptors. Does that mean we force every
plugin implementation to must Implement a hashCode and equals method. If so, I
think it makes it easy to cause mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
