reswqa commented on code in PR #19885:
URL: https://github.com/apache/flink/pull/19885#discussion_r891878743
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java:
##########
@@ -177,6 +177,32 @@ public boolean isReleaseByScheduler() {
return releaseType == ReleaseType.RELEASE_BY_SCHEDULER;
}
+ /**
+ * {@link #isBlockingOrBlockingPersistentResultPartition()} is used to
judge whether it is the
+ * specified {@link #BLOCKING} or {@link #BLOCKING_PERSISTENT}
resultPartitionType.
+ *
+ * <p>this method suitable for judgment conditions related to the specific
implementation of
+ * {@link ResultPartitionType}.
+ *
+ * <p>this method not related to data consumption and partition release.
As for the logic
+ * related to partition release, use {@link #isReleaseByScheduler()}
instead, and as consume
+ * type, use {@link #mustBePipelinedConsumed()} or {@link
#canBePipelinedConsumed()} instead.
+ */
+ public boolean isBlockingOrBlockingPersistentResultPartition() {
+ return this == BLOCKING || this == BLOCKING_PERSISTENT;
+ }
+
+ /**
+ * {@link #isPipelinedOrPipelinedBoundedResultPartition()} is used to
judge whether it is the
+ * specified {@link #PIPELINED} or {@link #PIPELINED_BOUNDED}
resultPartitionType.
+ *
+ * <p>This method suitable for judgment conditions related to the specific
implementation of
+ * {@link ResultPartitionType}.
+ *
+ * <p>This method not related to data consumption and partition release.
As for the logic
+ * related to partition release, use {@link #isReleaseByScheduler()}
instead, and as consume
+ * type, use {@link #mustBePipelinedConsumed()} or {@link
#canBePipelinedConsumed()} instead.
+ */
Review Comment:
good catch
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java:
##########
@@ -104,13 +118,40 @@ public enum ResultPartitionType {
*/
private final boolean isReconnectable;
+ private final ConsumeType consumeType;
+
+ private final ReleaseType releaseType;
+
+ /** ConsumeType indicates when can the downstream consume the upstream. */
+ private enum ConsumeType {
+ /** Upstream must be finished before downstream consume. */
+ BLOCKING,
+ /** Downstream can consume while upstream is running. */
+ CAN_BE_PIPELINED,
+ /** Downstream must consume while upstream is running. */
+ MUST_BE_PIPELINED
+ }
+
+ /** ReleaseType indicates who is responsible for releasing the result
partition. */
+ private enum ReleaseType {
+ RELEASE_BY_UPSTREAM,
+ RELEASE_BY_SCHEDULER
+ }
Review Comment:
open [FLINK-27948](https://issues.apache.org/jira/browse/FLINK-27948) to
track this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
