xintongsong commented on code in PR #19885:
URL: https://github.com/apache/flink/pull/19885#discussion_r891955828
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java:
##########
@@ -104,13 +107,46 @@ public enum ResultPartitionType {
*/
private final boolean isReconnectable;
+ private final ConsumingConstraint consumingConstraint;
+
+ private final ReleaseBy releaseBy;
+
+ /** ConsumeType indicates when can the downstream consume the upstream. */
+ private enum ConsumingConstraint {
+ /** Upstream must be finished before downstream consume. */
+ BLOCKING,
+ /** Downstream can consume while upstream is running. */
+ CAN_BE_PIPELINED,
+ /** Downstream must consume while upstream is running. */
+ MUST_BE_PIPELINED
+ }
+
+ /**
+ * ReleaseType indicates who is responsible for releasing the result
partition.
+ *
+ * <p>Attention: This may only be a short-term solution to deal with the
partition release
+ * logic. We can discuss the issue of unifying the partition release logic
in FLINK-27948. Once
+ * the ticket is resolved, we can remove the enumeration here.
+ */
+ private enum ReleaseBy {
+ UPSTREAM,
+ SCHEDULER
+ }
Review Comment:
Class name in JavaDoc not updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
