zentol commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r892085091
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and
test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+
<groupId>org.apache.maven.plugins</groupId>
+
<artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running
test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues
-->
Review Comment:
Do you have an example for such an issue?
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and
test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+
<groupId>org.apache.maven.plugins</groupId>
+
<artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running
test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues
-->
+ <forkCount>1</forkCount>
+
<reuseForks>false</reuseForks>
+
<systemPropertyVariables>
+
<derby.stream.error.file>${project.build.directory}/derby.log</derby.stream.error.file>
+
</systemPropertyVariables>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
<properties>
- <hive.version>3.1.1</hive.version>
+ <hive.version>3.1.2</hive.version>
Review Comment:
Why are we now also bumping hive? That should be a separate change.
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and
test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
Review Comment:
Ideally we drop the patch version from the profile id so we don't have to
touch the ci scripts every time we bump hive.
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and
test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+
<groupId>org.apache.maven.plugins</groupId>
+
<artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running
test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues
-->
+ <forkCount>1</forkCount>
+
<reuseForks>false</reuseForks>
Review Comment:
FYI this doesn't work because the settings in the unit/Itcase executions
take precedence.
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and
test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+
<groupId>org.apache.maven.plugins</groupId>
+
<artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running
test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues
-->
+ <forkCount>1</forkCount>
+
<reuseForks>false</reuseForks>
+
<systemPropertyVariables>
+
<derby.stream.error.file>${project.build.directory}/derby.log</derby.stream.error.file>
+
</systemPropertyVariables>
Review Comment:
This is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
