[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #153: [hotfix] Let ALTER TABLE COMPACT throw exception for APPEND ONLY table

Sun, 12 Jun 2022 23:23:35 -0700 


JingsongLi commented on code in PR #153:
URL: https://github.com/apache/flink-table-store/pull/153#discussion_r895362426


##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/StoreSink.java:
##########
@@ -119,6 +119,10 @@ public StatefulPrecommittingSinkWriter<WriterStateT> 
createWriter(InitContext in
     public StatefulPrecommittingSinkWriter<WriterStateT> restoreWriter(
             InitContext initContext, Collection<WriterStateT> states) throws 
IOException {
         if (compactionTask) {
+            if (writeMode == WriteMode.APPEND_ONLY) {

Review Comment:
   We should avoid this in compile phase.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to