luoyuxia commented on code in PR #19931:
URL: https://github.com/apache/flink/pull/19931#discussion_r895709798
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java:
##########
@@ -387,7 +387,9 @@ private static void
processPrimaryKeyInfos(HiveParserASTNode pkNode, List<PKInfo
}
private static void checkColumnName(String columnName) throws
SemanticException {
- if
(VirtualColumn.VIRTUAL_COLUMN_NAMES.contains(columnName.toUpperCase())) {
Review Comment:
Thanks for your reminder. But I also compile
`flink-sql-connector-hive-connector-3.1.2`, and the same exception throw.
Then, I decompile and check the class file
`org.apache.hadoop.hive.ql.metadata.VirtualColumn` in the
`flink-sql-connector-hive-connector-3.1.2.jar`. I found the the line `public
static final
org.apache.flink.hive.shaded.com.google.common.collect.ImmutableSet<java.lang.String>`.
However it's different from the type `VirtualColumn.VIRTUAL_COLUMN_NAMES` in
this method `checkColumnName`. So, the excpetion throw.
When replace with it with a method instead of field reference, we can solve
such problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
