zentol commented on code in PR #19931:
URL: https://github.com/apache/flink/pull/19931#discussion_r895734112


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java:
##########
@@ -387,7 +387,9 @@ private static void 
processPrimaryKeyInfos(HiveParserASTNode pkNode, List<PKInfo
     }
 
     private static void checkColumnName(String columnName) throws 
SemanticException {
-        if 
(VirtualColumn.VIRTUAL_COLUMN_NAMES.contains(columnName.toUpperCase())) {

Review Comment:
   That's because we relocate guava in flink-sql-connector-hive, but that is 
also applied to the the Flink code bundled in flink-sql-connector-hive, so it 
shouldn't matter.
   
   We are also still lacking an explanation for why this only fails with Hive 
3, and not with Hive 2 (which uses the same code with the same relocation).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to