zeus1ammon commented on PR #246: URL: https://github.com/apache/flink-kubernetes-operator/pull/246#issuecomment-1153972226
Sure. Sorry I was not actively checking the comments. Will address & test all the comments and commit it back in the next couple of days. thanks, Jagan On Fri, May 27, 2022 at 9:19 PM Márton Balassi ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > @zeus1ammon <https://github.com/zeus1ammon> do you think it would make > sense to add labels too if you are touching this anyway? > ------------------------------ > > In helm/flink-kubernetes-operator/templates/flink-operator.yaml > <https://github.com/apache/flink-kubernetes-operator/pull/246#discussion_r884046691> > : > > > @@ -34,6 +34,12 @@ spec: > {{- include "flink-operator.selectorLabels" . | nindent 8 }} > annotations: > kubectl.kubernetes.io/default-container: {{ .Chart.Name }} > + {{- $keyExist := .Values.operatorPodDeployment | default dict -}} > > This could be just if .Values.operatorPodDeployment.annotations, right? > We are using the same convention throughout the helm chart. > ------------------------------ > > In helm/flink-kubernetes-operator/values.yaml > <https://github.com/apache/flink-kubernetes-operator/pull/246#discussion_r884046757> > : > > > @@ -30,6 +30,9 @@ image: > rbac: > create: true > > +operatorPodDeployment: > > I find the name confusing. Is it for the pod or the deployment? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/flink-kubernetes-operator/pull/246#pullrequestreview-988265859>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AK3PE46YMBVJ5SPLLIALBJLVMFYCRANCNFSM5XFSL36A> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
