tsreaper commented on code in PR #158:
URL: https://github.com/apache/flink-table-store/pull/158#discussion_r898626398
##########
flink-table-store-hive/src/main/java/org/apache/flink/table/store/hive/HiveSchema.java:
##########
@@ -73,11 +90,134 @@ public static HiveSchema extract(Properties properties) {
String columnTypes =
properties.getProperty(serdeConstants.LIST_COLUMN_TYPES);
List<TypeInfo> typeInfos =
TypeInfoUtils.getTypeInfosFromTypeString(columnTypes);
+ List<String> partitionKeys = new ArrayList<>();
+ if
(properties.containsKey(hive_metastoreConstants.META_TABLE_PARTITION_COLUMNS)) {
Review Comment:
Why not? We can support partitions now that we have the real schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]