JingsongLi commented on code in PR #158:
URL: https://github.com/apache/flink-table-store/pull/158#discussion_r898751335
##########
flink-table-store-hive/src/main/java/org/apache/flink/table/store/TableStoreJobConf.java:
##########
@@ -45,23 +37,13 @@
public class TableStoreJobConf {
private static final String TBLPROPERTIES_PREFIX = "table-store.";
- private static final String TBLPROPERTIES_PRIMARY_KEYS =
TBLPROPERTIES_PREFIX + "primary-keys";
private static final String INTERNAL_TBLPROPERTIES_PREFIX =
"table-store.internal.tblproperties.";
private static final String INTERNAL_DB_NAME =
"table-store.internal.db-name";
Review Comment:
getDbName is never used
##########
flink-table-store-hive/src/main/java/org/apache/flink/table/store/TableStoreJobConf.java:
##########
@@ -45,23 +37,13 @@
public class TableStoreJobConf {
private static final String TBLPROPERTIES_PREFIX = "table-store.";
- private static final String TBLPROPERTIES_PRIMARY_KEYS =
TBLPROPERTIES_PREFIX + "primary-keys";
private static final String INTERNAL_TBLPROPERTIES_PREFIX =
"table-store.internal.tblproperties.";
private static final String INTERNAL_DB_NAME =
"table-store.internal.db-name";
private static final String INTERNAL_TABLE_NAME =
"table-store.internal.table-name";
Review Comment:
getTableName is never used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
