morhidi commented on code in PR #254:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/254#discussion_r900053993
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -109,14 +117,19 @@ public Configuration getDefaultConfig() {
@VisibleForTesting
public void updateDefaultConfig(Configuration newConf) {
- if (newConf.equals(defaultConfig)) {
+ if (defaultConfig != null
+ && newConf != null
Review Comment:
Yes, this is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
