morhidi commented on code in PR #254:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/254#discussion_r900054810
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -109,14 +117,19 @@ public Configuration getDefaultConfig() {
@VisibleForTesting
public void updateDefaultConfig(Configuration newConf) {
- if (newConf.equals(defaultConfig)) {
+ if (defaultConfig != null
+ && newConf != null
+ && defaultConfig.toMap().equals(newConf.toMap())) {
LOG.info("Default configuration did not change, nothing to do...");
return;
}
LOG.info("Updating default configuration to {}", newConf);
- this.operatorConfiguration =
- FlinkOperatorConfiguration.fromConfiguration(newConf,
namespaces);
+ this.operatorConfiguration =
FlinkOperatorConfiguration.fromConfiguration(newConf);
+
+ if (this.operatorConfiguration.getDynamicNamespacesEnabled()) {
Review Comment:
Sure, I'll add an extra check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
